[PATCH] udev: udpate udev to detect new 7xxx modems

[Nandini Rebello]

Newer intel modems enumerate with different subsystem numbers,
adding code to detect newer 7xxx modules.

Plan to add patch for backward compatibility of intels modems soon,
to based on interface number instead of subsystem name string.
---
plugins/udevng.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/plugins/udevng.c b/plugins/udevng.c
index 11338f7..bf0b1c4 100644
--- a/plugins/udevng.c
+++ b/plugins/udevng.c
@@ -1194,10 +1194,10 @@ static gboolean setup_xmm7xxx(struct modem_info *modem)
info->sysattr, info->subsystem);

if (g_strcmp0(info->subsystem, "tty") == 0) {
- if (g_strcmp0(info->number, "02") == 0)
+ if (g_strcmp0(info->number, "00") == 0)
mdm = info->devnode;
} else if (g_strcmp0(info->subsystem, "net") == 0) {
- if (g_strcmp0(info->number, "00") == 0)
+ if (g_strcmp0(info->number, "06") == 0)
net = info->devnode;
}
}

[Navik, Ankit P]

Hi Nandini,

-----Original Message-----
Sent: Wednesday, October 31, 2018 12:26 PM
Subject: [PATCH] udev: udpate udev to detect new 7xxx modems
Newer intel modems enumerate with different subsystem numbers, adding code
to detect newer 7xxx modules.
Plan to add patch for backward compatibility of intels modems soon, to based
on interface number instead of subsystem name string.
---
plugins/udevng.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/plugins/udevng.c b/plugins/udevng.c index 11338f7..bf0b1c4 100644
--- a/plugins/udevng.c
+++ b/plugins/udevng.c
@@ -1194,10 +1194,10 @@ static gboolean setup_xmm7xxx(struct
modem_info *modem)
info->sysattr, info->subsystem);
if (g_strcmp0(info->subsystem, "tty") == 0) {
- if (g_strcmp0(info->number, "02") == 0)
+ if (g_strcmp0(info->number, "00") == 0)
mdm = info->devnode;
} else if (g_strcmp0(info->subsystem, "net") == 0) {
- if (g_strcmp0(info->number, "00") == 0)
+ if (g_strcmp0(info->number, "06") == 0)

Can this be maintained as separate patch in board support package ?
The reason is, this will be keep on getting change with different series of xmm modem.

Regards,
Ankit

net = info->devnode;
}
}
--
2.7.4
_______________________________________________
ofono mailing list
https://lists.ofono.org/mailman/listinfo/ofono

[Rebello, Nandini]

Hi,

Happen to spend time with old modems and validated code. Found a more cleaner approach.
Please consider the next path.

Regards,
Nandini

-----Original Message-----
From: Giacinto Cifelli [mailto:***@gmail.com]
Sent: Wednesday, October 31, 2018 12:29 PM
To: Rebello, Nandini <***@intel.com>
Cc: ***@ofono.org; Borwankar, Antara <***@intel.com>; Gargi, Anirudh <***@intel.com>
Subject: Re: [PATCH] udev: udpate udev to detect new 7xxx modems

Hi,

Newer intel modems enumerate with different subsystem numbers, adding
code to detect newer 7xxx modules.
Plan to add patch for backward compatibility of intels modems soon, to
based on interface number instead of subsystem name string.
---
plugins/udevng.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/plugins/udevng.c b/plugins/udevng.c index
11338f7..bf0b1c4 100644
--- a/plugins/udevng.c
+++ b/plugins/udevng.c
@@ -1194,10 +1194,10 @@ static gboolean setup_xmm7xxx(struct modem_info *modem)
info->sysattr, info->subsystem);
if (g_strcmp0(info->subsystem, "tty") == 0) {
- if (g_strcmp0(info->number, "02") == 0)
+ if (g_strcmp0(info->number, "00") == 0)

but then all current users of the models using the usb device 02 (and
00 below) will be cut off if they update to this patch.
Maybe you need to add the switching logic you mentioned above based on interface number in the same patch.

mdm = info->devnode;
} else if (g_strcmp0(info->subsystem, "net") == 0) {
- if (g_strcmp0(info->number, "00") == 0)
+ if (g_strcmp0(info->number, "06") == 0)
net = info->devnode;
}
}
--
2.7.4
_______________________________________________
ofono mailing list
https://lists.ofono.org/mailman/listinfo/ofono

regards,
Giacinto