Discussion:
[PATCH 2/2] netmon: Enabled netmon atom for xmm7modem plugin
Antara Borwankar
2018-10-09 11:26:14 UTC
Permalink
From: Antara <***@intel.com>

enabling netmon atom to report current serving cell measurements
for xmm7modem
---
Makefile.am | 3 ++-
plugins/xmm7xxx.c | 2 ++
2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index 6dee4ce..e4ea2ae 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -404,7 +404,8 @@ builtin_sources += drivers/atmodem/atutil.h \
drivers/xmm7modem/xmm7modem.h \
drivers/xmm7modem/xmm7modem.c \
drivers/xmm7modem/radio-settings.c \
- drivers/xmm7modem/ims.c
+ drivers/xmm7modem/ims.c \
+ drivers/xmm7modem/netmon.c

if PHONESIM
builtin_modules += phonesim
diff --git a/plugins/xmm7xxx.c b/plugins/xmm7xxx.c
index 9db87ad..6008cf9 100644
--- a/plugins/xmm7xxx.c
+++ b/plugins/xmm7xxx.c
@@ -50,6 +50,7 @@
#include <ofono/lte.h>
#include <ofono/ims.h>
#include <ofono/sim-auth.h>
+#include <ofono/netmon.h>

#include <drivers/atmodem/atutil.h>
#include <drivers/atmodem/vendor.h>
@@ -347,6 +348,7 @@ static void xmm7xxx_post_online(struct ofono_modem *modem)
ofono_gprs_add_context(gprs, gc);

ofono_ims_create(modem, "xmm7modem", data->chat);
+ ofono_netmon_create(modem, 0, "xmm7modem", data->chat);
}

static int xmm7xxx_probe(struct ofono_modem *modem)
--
1.9.1
Antara Borwankar
2018-10-09 11:42:10 UTC
Permalink
From: Antara <***@intel.com>

enabling netmon atom to report current serving cell measurements
for xmm7modem
---
Makefile.am | 3 ++-
plugins/xmm7xxx.c | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index 10ace55..6667524 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -404,7 +404,8 @@ builtin_sources += drivers/atmodem/atutil.h \
drivers/xmm7modem/xmm7modem.h \
drivers/xmm7modem/xmm7modem.c \
drivers/xmm7modem/radio-settings.c \
- drivers/xmm7modem/ims.c
+ drivers/xmm7modem/ims.c \
+ drivers/xmm7modem/netmon.c

if PHONESIM
builtin_modules += phonesim
diff --git a/plugins/xmm7xxx.c b/plugins/xmm7xxx.c
index 066e2e7..243738e 100644
--- a/plugins/xmm7xxx.c
+++ b/plugins/xmm7xxx.c
@@ -356,6 +356,7 @@ static void xmm7xxx_post_online(struct ofono_modem *modem)
ofono_gprs_add_context(gprs, gc);

ofono_ims_create(modem, "xmm7modem", data->chat);
+ ofono_netmon_create(modem, 0, "xmm7modem", data->chat);
}

static int xmm7xxx_probe(struct ofono_modem *modem)
--
1.9.1
Denis Kenzior
2018-10-09 17:57:22 UTC
Permalink
Hi Antara,
Post by Antara Borwankar
diff --git a/plugins/xmm7xxx.c b/plugins/xmm7xxx.c
index 066e2e7..243738e 100644
--- a/plugins/xmm7xxx.c
+++ b/plugins/xmm7xxx.c
I also added '#include <ofono/netmon.h>' at the top of this file.
Post by Antara Borwankar
@@ -356,6 +356,7 @@ static void xmm7xxx_post_online(struct ofono_modem *modem)
ofono_gprs_add_context(gprs, gc);
ofono_ims_create(modem, "xmm7modem", data->chat);
+ ofono_netmon_create(modem, 0, "xmm7modem", data->chat);
}
static int xmm7xxx_probe(struct ofono_modem *modem)
Applied, thanks.

Regards,
-Denis

Loading...