Discussion:
[PATCH] sms:fix a missing entry in single shift table
Nandini Rebello
2018-10-11 11:23:32 UTC
Permalink
Fix a missing char in the nation language set in single shift table
for a special character. Character set again validated.

Future language table to carry this fix.
---
src/util.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/src/util.c b/src/util.c
index 2f01cec..70d72d7 100644
--- a/src/util.c
+++ b/src/util.c
@@ -376,6 +376,7 @@ static const struct codepoint ben_ext_gsm[] = {
};

static const struct codepoint ben_ext_unicode[] = {
+ { 0x000C, 0x1B0A },
{ 0x0022, 0x1B05 },
{ 0X0023, 0x1B17 },
{ 0x0024, 0x1B02 },
@@ -535,6 +536,7 @@ static const struct codepoint guj_ext_gsm[] = {
};

static const struct codepoint guj_ext_unicode[] = {
+ { 0x000C, 0x1B0A },
{ 0x0022, 0x1B05 },
{ 0x0023, 0x1B17 },
{ 0x0024, 0x1B02 },
--
2.7.4
Denis Kenzior
2018-10-11 15:18:30 UTC
Permalink
Hi Nandini,
Post by Nandini Rebello
Fix a missing char in the nation language set in single shift table
for a special character. Character set again validated.
Future language table to carry this fix.
---
src/util.c | 2 ++
1 file changed, 2 insertions(+)
Applied, thanks.

You may want to add unit tests for each new alphabet you introduce into
unit/test-sms.c. I think we have some sanity checks in there for
Spanish/etc alphabets already.

Regards,
-Denis

Loading...