[PATCH] atmodem/sms: added Gemalto vendor for CNMI command

[Jonas Bonn]

Hi,

---
drivers/atmodem/sms.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/atmodem/sms.c b/drivers/atmodem/sms.c
index 7638885e..380cd763 100644
--- a/drivers/atmodem/sms.c
+++ b/drivers/atmodem/sms.c
@@ -858,8 +858,18 @@ static gboolean build_cnmi_string(char *buf, int *cnmi_opts,
data->cnma_enabled ? "21" : "1", FALSE))
return FALSE;
+ switch (data->vendor) {
+ mode = "0";
+ break;
+ /* Sounds like 2 is the sanest mode */

This particular comment doesn't add anything useful so just drop it.

/Jonas

+ mode = "20";
+ break;
+ }
+
/* Always deliver CB via +CBM, otherwise don't deliver at all */
- if (!append_cnmi_element(buf, &len, cnmi_opts[2], "20", FALSE))
+ if (!append_cnmi_element(buf, &len, cnmi_opts[2], mode, FALSE))
return FALSE;
/*

[Jonas Bonn]

Hi,
+ break;

Post by Jonas Bonn

+ /* Sounds like 2 is the sanest mode */

This particular comment doesn't add anything useful so just drop it.

Not mine... I didn't want my patch rejected because I changed 2 things
at the same time (add vendor and remove comment).
From the choice of word (sane), I think this comment is from Denis.
without even checking with git blame.

:)

/Jonas

[Denis Kenzior]

Hi Giacinto,

---
drivers/atmodem/sms.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)

Applied, thanks.

Regards,
-denis