Discussion:
[PATCH] Fix error handling in at_cmt_notify()
Pavel Machek
2018-09-27 21:47:24 UTC
Permalink
at_cmt_notify() calls ofono_error even in case stuff is
okay. Fix that.

diff --git a/drivers/atmodem/sms.c b/drivers/atmodem/sms.c
index 68b89862..217971e7 100644
--- a/drivers/atmodem/sms.c
+++ b/drivers/atmodem/sms.c
@@ -440,6 +436,8 @@ static void at_cmt_notify(GAtResult *result, gpointer user_data)
if (data->vendor != OFONO_VENDOR_SIMCOM)
at_ack_delivery(sms);

+ return;
+
err:
ofono_error("Unable to parse CMT notification");
}
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Denis Kenzior
2018-09-27 22:18:19 UTC
Permalink
Hi Pavel,
Post by Pavel Machek
at_cmt_notify() calls ofono_error even in case stuff is
okay. Fix that.
I think this was already fixed upstream.

Regards,
-Denis

Loading...